Skip to content

Replace current cloud info url call by Cloud Info client#7065

Merged
pditommaso merged 1 commit intomasterfrom
google-cloud-info-client-replacement
Apr 24, 2026
Merged

Replace current cloud info url call by Cloud Info client#7065
pditommaso merged 1 commit intomasterfrom
google-cloud-info-client-replacement

Conversation

@jorgee
Copy link
Copy Markdown
Contributor

@jorgee jorgee commented Apr 23, 2026

This pull request updates the Google Batch machine type selection logic to use the new lib-cloudinfo client library instead of manual HTTP requests and JSON parsing. This contains default retries as well as connection and request timeouts.

Dependency update:

  • Added io.seqera:lib-cloudinfo:1.0.0 as an API dependency in build.gradle to enable use of the CloudInfo client library.

Refactoring to use CloudInfo client:

  • Replaced manual HTTP requests and JSON parsing in GoogleBatchMachineTypeSelector.groovy with the CloudInfoClient API for retrieving product and pricing information.
  • Imported CloudPrice and CloudInfoClient from the new library and initialized a CloudInfoClient instance in the selector class. [1] [2]
  • Removed the hardcoded CLOUD_INFO_API URL, as the client library now handles API endpoint management.

Signed-off-by: jorgee <jorge.ejarque@seqera.io>
@netlify
Copy link
Copy Markdown

netlify Bot commented Apr 23, 2026

Deploy Preview for nextflow-docs-staging ready!

Name Link
🔨 Latest commit 96afa57
🔍 Latest deploy log https://app.netlify.com/projects/nextflow-docs-staging/deploys/69ea28219b690c0008dd7436
😎 Deploy Preview https://deploy-preview-7065--nextflow-docs-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Copy Markdown
Member

@pditommaso pditommaso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done

Comment thread plugins/nf-google/build.gradle
@pditommaso pditommaso merged commit 6291842 into master Apr 24, 2026
31 checks passed
@pditommaso pditommaso deleted the google-cloud-info-client-replacement branch April 24, 2026 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants